Add GitHub clang-format-16 check and indent accordingly#414
Open
masterleinad wants to merge 3 commits intokokkos:stablefrom
Open
Add GitHub clang-format-16 check and indent accordingly#414masterleinad wants to merge 3 commits intokokkos:stablefrom
masterleinad wants to merge 3 commits intokokkos:stablefrom
Conversation
masterleinad
force-pushed
the
clang-format
branch
2 times, most recently
from
a9e99b3 to
0906881
Compare
masterleinad
changed the title
dalg24
reviewed
Jun 16, 2025
Comment on lines
+3
to
+6
| SortIncludes: false | ||
| AlignConsecutiveAssignments: true | ||
| AllowShortCaseLabelsOnASingleLine: true | ||
| AllowShortIfStatementsOnASingleLine: true |
Member
There was a problem hiding this comment.
Note that there is no mandate to adopt the same style as Kokkos Core
Member
There was a problem hiding this comment.
I would recommend picking something that minimizes the diff.
masterleinad
force-pushed
the
clang-format
branch
from
0906881 to
5e71eaf
Compare
nmm0
approved these changes
Jun 16, 2025
masterleinad
force-pushed
the
clang-format
branch
from
5e71eaf to
3c1cc4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #413 (comment) and #285 (comment), this pull request enforces the repository to be formatted with clang-format 16 using the same settings as for https://github.com/kokkos/kokkos.